Trusted publishing: Enforce strict audience checking #14158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
di
reviewed
Jul 18, 2023
Co-authored-by: Dustin Ingram <[email protected]>
|
@woodruffw A test to ensure this doesn't regress would be nice! |
Sounds good, doing now. |
Signed-off-by: William Woodruff <[email protected]>
|
Done: I've added a test on both our own JWT helper and a "backstop" test on |
woodruffw
commented
Jul 18, 2023
Comment on lines
+966
to
+968
| def __init__(self) -> None: | ||
| self._privkey = rsa.generate_private_key(65537, 2048) | ||
| self._pubkey = self._privkey.public_key() |
There was a problem hiding this comment.
Diff is messy here, but I took the opportunity to optimize this test group a bit (RSA keygen is pretty slow and the keys don't need to be unique per-test, so I'm having them reuse the same keypair rather than regenerating each time.)
di
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps
pyjwtto 2.8.0 and uses the newly-addedstrict_audoption to ensure that we reject JWTs that don't contain exactly a single stringaudclaim.Closes #13887.