Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python GraphQL client library #208

Merged
merged 13 commits into from
Nov 9, 2024
Merged

Use Python GraphQL client library #208

merged 13 commits into from
Nov 9, 2024

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Nov 7, 2024

Use a Python GraphQL library instead of implement GraphQL internally.

includes #210 and #211

@jschlyter jschlyter linked an issue Nov 7, 2024 that may be closed by this pull request
@jschlyter jschlyter changed the title Use GraphQL client library Use Python GraphQL client library Nov 8, 2024
@jschlyter
Copy link
Contributor Author

I could use some help testing this - perhaps @wouterhardeman ?

@jschlyter jschlyter added enhancement New feature or request help wanted Extra attention is needed labels Nov 8, 2024
@jschlyter jschlyter marked this pull request as ready for review November 8, 2024 17:07
@jschlyter jschlyter requested a review from a team as a code owner November 8, 2024 17:07
Copy link

@wouterhardeman wouterhardeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jschlyter, I went through it and found 2 small things. Let me know what you think!

Also I'm not a member of the organization (although I'd be happy to join 😄) so @leeyuentuen will need to approve this.

custom_components/polestar_api/pypolestar/auth.py Outdated Show resolved Hide resolved
@jschlyter jschlyter merged commit cd7c6df into pypolestar:main Nov 9, 2024
3 checks passed
@jschlyter jschlyter deleted the gql branch November 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Python GraphQL library
2 participants