-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Health Data sensors #225
base: main
Are you sure you want to change the base?
Add Health Data sensors #225
Conversation
daysToService | ||
distanceToServiceKm | ||
engineCoolantLevelWarning | ||
eventUpdatedTimestamp { iso unix } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably drop the unix format request if we're not using it.
Perhaps we can merge process #227 first and then update this with dataclass models? |
Yeah I agree, I'll go review that PR tomorrow! |
You want #241 merged to fix some issues with the model I believe. |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There are some additional work on the dataclasses and sensors #249 that will simplify this PR. |
This PR adds support for the new car health API.
TODO:
Resolves #183