Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #1086

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add Python 3.12 support #1086

merged 2 commits into from
Nov 6, 2023

Conversation

foarsitter
Copy link
Contributor

@foarsitter foarsitter commented Nov 1, 2023

Without any changes this project supports Python 3.12. So version 4.6.0 is already compatible with Python 3.12

@adamchainz
Copy link
Member

adamchainz commented Nov 1, 2023

We need to add 3.12 to the test matrix. I think we should wait until we have Django 5.0 tested, because it is the only Django version that officially supports Python 3.2. (For now, that is. Django 4.2 will probably add support at some point.)

Edit: opened #1087 for Django 5.0 support.

@adamchainz adamchainz changed the title Add Python 3.12 to test matrix and as classifier Add Python 3.12 support Nov 1, 2023
@foarsitter
Copy link
Contributor Author

Unofficially pytest-django already supports 3.12 so in my opinion there is no reason to wait for 5.0. I would point to https://forum.djangoproject.com/t/django-4-2-lts-compatibility-with-python-3-12/24508/3 to tell support for 3.12 is comming to 4.2 but you are the author of that posts.

@adamchainz
Copy link
Member

After merging #1087, I rebased this branch and added a commit with the changelog note + github actions run.

@foarsitter
Copy link
Contributor Author

@adamchainz LGTM, thanks!

@adamchainz adamchainz merged commit be1163b into pytest-dev:master Nov 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants