event check is done, I think

caldav/davclient.py

@@ -211,6 +211,7 @@ def _parse_response(self, response) -> Tuple[str, List[_Element], Optional[Any]]
         status = None
         href: Optional[str] = None
         propstats: List[_Element] = []
+        check_404 = False ## special for purelymail
         error.assert_(response.tag == dav.Response.tag)
         for elem in response:
             if elem.tag == dav.Status.tag:
@@ -223,13 +224,27 @@ def _parse_response(self, response) -> Tuple[str, List[_Element], Optional[Any]]
                 href = unquote(elem.text)
             elif elem.tag == dav.PropStat.tag:
                 propstats.append(elem)
+            elif elem.tag == '{DAV:}error':
+                ## This happens with purelymail on a 404.
+                ## This code is mostly moot, but in debug
+                ## mode I want to be sure we do not toss away any data
+                children = elem.getchildren()
+                error.assert_(len(children)==1)
+                error.assert_(children[0].tag=='{https://purelymail.com}does-not-exist')
+                check_404 = True
             else:
-                error.assert_(False)
+                ## i.e. purelymail may contain one more tag, <error>...</error>
+                ## This is probably not a breach of the standard.  It may
+                ## probably be ignored.  But it's something we may want to
+                ## know.
+                error.weirdness("unexpected element found in response", elem)
         error.assert_(href)
+        if check_404:
+            error.assert_('404' in status)
         ## TODO: is this safe/sane?
         ## Ref https://github.com/python-caldav/caldav/issues/435 the paths returned may be absolute URLs,
         ## but the caller expects them to be paths.  Could we have issues when a server has same path
-        ## but different URLs for different elements?
+        ## but different URLs for different elements?  Perhaps href should always be made into an URL-object?
         if ":" in href:
             href = unquote(URL(href).path)
         return (cast(str, href), propstats, status)

caldav/lib/debug.py

@@ -2,6 +2,8 @@
 
 
 def xmlstring(root):
+    if isinstance(root, str):
+        return root
     if hasattr(root, "xmlelement"):
         root = root.xmlelement()
     return etree.tostring(root, pretty_print=True).decode("utf-8")

caldav/lib/error.py

@@ -25,6 +25,13 @@
 else:
     log.setLevel(logging.WARNING)
 
+def weirdness(*reasons):
+    from caldav.lib.debug import xmlstring
+    reason = " : ".join([xmlstring(x) for x in reasons])
+    log.warning(f"Deviation from expectations found: {reason}")
+    if debugmode == "DEBUG_PDB":
+        log.error(f"Dropping into debugger due to {reason}")
+        import pdb; pdb.set_trace()
 
 def assert_(condition: object) -> None:
     try:
@@ -36,9 +43,7 @@ def assert_(condition: object) -> None:
             )
         elif debugmode == "DEBUG_PDB":
             log.error("Deviation from expectations found.  Dropping into debugger")
-            import pdb
-
-            pdb.set_trace()
+            import pdb; pdb.set_trace()
         else:
             raise
 

caldav/objects.py

@@ -791,7 +791,7 @@ def _create(
         if name:
             try:
                 self.set_properties([display_name])
-            except:
+            except Exception as e:
                 ## TODO: investigate.  Those asserts break.
                 error.assert_(False)
                 try: