Partial revert of 075841971b603bbe5774880ee1fa6abf778b84b0 #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An "import *" was removed in above commit. Yes, "import *" is bad practice - but since those things are reimported other places, we can't remove it in a minor release. First we need some kind of deprecation notice, then we need to remove it when doing a major release. I aim for every major release to be backward compatible with everything that wasn't marked as deprecated in the previous x.0.0 major release, so 3.0 is the earliest we can remove this.
tobixen
force-pushed
the
backward-compatibility-fix
branch
from
5a9e6fe to
b324044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "import *" was removed in above commit. Yes, "import *" is bad practice - but since those things are reimported other places, we can't remove it in a minor release. First we need some kind of deprecation notice, then we need to remove it when doing a major release. I aim for every major release to be backward compatible with everything that wasn't marked as deprecated in the previous x.0.0 major release, so 3.0 is the earliest we can remove this.