Change fixup log lvl to warning and merge diff log messages into related parent log #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures are unrelated to the pull request. It should probably be raised in the xandikos project. @jelmer ? |
|
Those issues are fixed in xandikos master; I'll see if I can do a release today. |
|
thanks |
|
Released now |
tobixen
pushed a commit
that referenced
this pull request
Oct 20, 2024
Solves #426 Also changes multiple log lines into a multi-line log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the two fix up log messages into one. The diff log can be confusing when the log is viewed outside the console. (see image from Home Assistants log view)
I haven't touched the log level yet.See: #426 (comment)