Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use niquests #452

Closed

Conversation

ArtemIsmagilov
Copy link
Contributor

I would like to integrate this library. ll the advantages can be read here https://pypi.org/project/niquests/

What is the benefit of this caldav project?

  • multiplexing (increasing productivity)
  • support for asynchrony (you can add asynchronous interfaces)
  • full compatibility with requests
  • lots of functionality

@tobixen
Copy link
Member

tobixen commented Nov 20, 2024

Making the caldav library async would be good, but I will have to read up a bit on this.

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

The part with doing requests (and particularly authentication) is actually quite fragile - much more fragile as it ought to be - there are many fragile server setups out there, I've had people filing bug reports almost every time I've been doing changes on it, After reading and sleeping on this, I've concluded to take niquest into the master branch, but exclude it from any 1.x-releases. I will make a 1.x-branch and backport all commits there that are not related or dependent on niquests.

This means the python 3.13-support, which is unrelated to nirequest, has to go into a separate pull request.

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

There is also the security aspect of depending on a new library with one maintainer/developer - the library haven't had too many eyeballs so far, and we've had some nasty supply-side attacks in the open source community throughout the last few years. However, if would be very sad if nobody picks up niquest because niquest has "too few eyeballs".

@ArtemIsmagilov
Copy link
Contributor Author

Hi, great! et's do it like that!

To be honest, for some reason you use authentication yourself. Fortunately, there are already different classes and even arguments for different types of authentication. you should try using authentication out of the box.

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

Yes. I always said that the authentication code did not belong in the caldav library at all, but the requests library does not simply take username and password/token as inputs, one needs to fiddle with the authentication manually. And now the authentication code contains tweaks to support weird server setups, so we're a bit stuck with it.

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

Could you move the python 3.13 support over to a separate pull request?

@ArtemIsmagilov
Copy link
Contributor Author

Of course, thank you for giving me the opportunity!

@ArtemIsmagilov
Copy link
Contributor Author

I'm sorry, I think I screwed up a bit.

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

Maybe the simplest is to cancel this pull request and make a new one with only one commit in it

@tobixen
Copy link
Member

tobixen commented Nov 21, 2024

All the white space changes in the toml file makes this complicated :-)

@ArtemIsmagilov ArtemIsmagilov mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants