-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use niquests #452
use niquests #452
Conversation
Making the caldav library async would be good, but I will have to read up a bit on this. |
The part with doing requests (and particularly authentication) is actually quite fragile - much more fragile as it ought to be - there are many fragile server setups out there, I've had people filing bug reports almost every time I've been doing changes on it, After reading and sleeping on this, I've concluded to take niquest into the master branch, but exclude it from any 1.x-releases. I will make a 1.x-branch and backport all commits there that are not related or dependent on niquests. This means the python 3.13-support, which is unrelated to nirequest, has to go into a separate pull request. |
There is also the security aspect of depending on a new library with one maintainer/developer - the library haven't had too many eyeballs so far, and we've had some nasty supply-side attacks in the open source community throughout the last few years. However, if would be very sad if nobody picks up niquest because niquest has "too few eyeballs". |
Hi, great! et's do it like that! To be honest, for some reason you use authentication yourself. Fortunately, there are already different classes and even arguments for different types of authentication. you should try using authentication out of the box. |
Yes. I always said that the authentication code did not belong in the caldav library at all, but the |
Could you move the python 3.13 support over to a separate pull request? |
Of course, thank you for giving me the opportunity! |
This reverts commit e9bcd89.
I'm sorry, I think I screwed up a bit. |
Maybe the simplest is to cancel this pull request and make a new one with only one commit in it |
All the white space changes in the toml file makes this complicated :-) |
I would like to integrate this library. ll the advantages can be read here https://pypi.org/project/niquests/
What is the benefit of this caldav project?
requests