-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure AD B2C base url to the latest url as stated in the Microsoft docs #459
base: master
Are you sure you want to change the base?
Update Azure AD B2C base url to the latest url as stated in the Microsoft docs #459
Conversation
I recently ran into this situation and had to create a new backend locally for this. I'm unclear on if (or how) the current Azure B2C backend would still be functional for anyone based on the changes Microsoft has made recently to this flow. The only thing I can think of is that they may still be maintaining backwards compatibility for B2C tenants that were created prior to some date in the past. I'd love to hear feedback from anyone using the Azure B2C backend. Thanks! |
Looks good. Can you please also add documentation for this to https://github.com/python-social-auth/social-docs/blob/master/docs/backends/azuread.rst? |
@nijel How can I test this? Can I get this PR as a docker image somehow so that I can easily run it in my cloud environment? Also, the status above indicates some conflicts. I am happy to help if you guys assist and guide me. |
I think this can be closed, since #777 did the similar thing? |
def tenant_id(self): | ||
return self.setting('TENANT_ID', 'common') | ||
def tenant_name(self): | ||
return self.setting('TENANT_NAME', 'common') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks setup for existing users, are these different, or this is just a different name for the same value?
Proposed changes
Using login.microsoftonline.com for Azure AD B2C has been deprecated and it will be removed later this year. See Deprecation notice. Even though login.microsoftonline.com is still being supported by Microsoft I was not able to get it working for a new Azure AD B2C Tenant. Updating the BASE_URL to the new url and moving the policy to the url itself instead of a query parameter works correctly. This is how it's stated in the latest docs for Azure AD B2C OpenID Connect.
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_ID was changed to SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_NAME since only the tenant name is needed now.