Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linkedin userdetails backend #915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MohamedAhmed412000
Copy link

@MohamedAhmed412000 MohamedAhmed412000 commented May 18, 2024

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@nijel
Copy link
Member

nijel commented May 20, 2024

  • Can you please provide some references why such a change is needed?
  • Can you please adjust tests?

@MohamedAhmed412000
Copy link
Author

image
This is the updated endpoint for getting the user details from linkedin service account

image
and those are the scopes returned from openid-auth

@rajpipaliya048
Copy link

rajpipaliya048 commented Jul 22, 2024

i've tested the changes.

i think there's no need for projection param in USER_DETAILS_URL variable.

also, here's the official doc url for new scopes
https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2#authenticating-members

@nijel
Copy link
Member

nijel commented Jul 24, 2024

Thanks for verifying the fix, we still need test suite to pass to be able to merge this.

@rajpipaliya048
Copy link

Thanks for verifying the fix, we still need test suite to pass to be able to merge this.

yup!

if you need anykind of help let me know!
i was doing the same thing so i have idea about this

@nijel
Copy link
Member

nijel commented Jul 26, 2024

I have no clue if @MohamedAhmed412000 is interested in pushing this forward, if not, adjusting testsuite is the way to get this merged.

@MohamedAhmed412000
Copy link
Author

I will adjust the tests inshallah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Linkedin OAuth dont work due new Linkedin scopes. LinkedIn Login not working, needs to be updated
3 participants