Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 13: Add STAR voting and misc tidbits #3958

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 12, 2024

  • Because this is a process PEP, and specifically the one that defines the powers of the SC, the SC does not need to approve this PEP.
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--3958.org.readthedocs.build/pep-0013/

peps/pep-0013.rst Outdated Show resolved Hide resolved
peps/pep-0013.rst Outdated Show resolved Hide resolved
peps/pep-0013.rst Outdated Show resolved Hide resolved
@gvanrossum
Copy link
Member Author

Question for the SC (primarily): If I were to commit this today, it would appear to affect the upcoming election for SC2025. That's not a good idea, because we'd have to scramble to figure out exactly how to run the election. So my plan has always been to make this go into effect for the election after the upcoming one, voting for SC2026.

I can think of a few ways to implement that plan:

  • Update the text of the PR slightly to explicitly state "for elections in or after 2025" or some such. (Awkward: not the text that was voted for.)
  • Update the PEP now with the unstated assumption that it goes into effect next year. Not great.
  • Similar, but add a .. note:: explaining that it starts after June 2025, for example. (A little awkward, but we can always remove the note once it's no longer relevant.)
  • Hold off merging this PR until the upcoming election is over. (Elegant, but that means about two months until we see the change.)

What would the current SC prefer that I do?

@gvanrossum
Copy link
Member Author

What would the current SC prefer that I do?

I made a mistake here -- since PEP 13 defines the SC's powers, it's inappropriate for the SC to be involved here. I've decided to just postpone committing this PR until the upcoming election is done. See the discussion in Discourse.

@gvanrossum gvanrossum marked this pull request as ready for review December 10, 2024 17:19
@gvanrossum gvanrossum requested a review from a team as a code owner December 10, 2024 17:19
@gvanrossum gvanrossum merged commit e4f3216 into python:main Dec 10, 2024
5 checks passed
@gvanrossum gvanrossum deleted the star branch December 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants