Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 757: address gpshead's review #4144

Merged
merged 7 commits into from
Dec 3, 2024
Merged

PEP 757: address gpshead's review #4144

merged 7 commits into from
Dec 3, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Dec 2, 2024 •
edited by gpshead
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4144.org.readthedocs.build/

@skirpichev skirpichev requested a review from gpshead December 2, 2024 03:43
@skirpichev skirpichev marked this pull request as ready for review December 2, 2024 04:31
@skirpichev skirpichev requested a review from vstinner as a code owner December 2, 2024 04:31
@skirpichev
Copy link
Member Author

skirpichev commented Dec 2, 2024 •
edited
Loading

The pr doesn't address yet the review comment to simplify the reading API (a-la revert the d6ad15e).

If my comment in the discussion thread convince @gpshead that current design has benefits - I'll expand the "Rejected Ideas". Edit: but I think this stuff anyway is better suited to a separate pr.

@vstinner
Copy link
Member

vstinner commented Dec 2, 2024

Ah, the feedback is this thread: https://discuss.python.org/t/pep-757-c-api-to-import-export-python-integers/63895/74

hugovk
hugovk reviewed Dec 2, 2024
View reviewed changes
peps/pep-0757.rst Outdated Show resolved Hide resolved
peps/pep-0757.rst Outdated Show resolved Hide resolved
peps/pep-0757.rst Outdated Show resolved Hide resolved
@skirpichev @hugovk
Apply suggestions from code review
f1137b3 
Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead gpshead changed the title PEP 757: address SC review PEP 757: address gpshead's review Dec 2, 2024
@vstinner vstinner merged commit bf6f2d4 into python:main Dec 3, 2024
5 checks passed
@vstinner
Copy link
Member

vstinner commented Dec 3, 2024

Merged, thanks.

@skirpichev skirpichev deleted the pep757-sc-edits branch December 3, 2024 14:27
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@skirpichev @hugovk @gvanrossum
PEP 757: address gpshead's review (python#4144)
511bab9 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@gpshead gpshead Awaiting requested review from gpshead

@vstinner vstinner Awaiting requested review from vstinner vstinner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @vstinner @hugovk