Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 736: Final Draft #4145

Merged
merged 9 commits into from
Dec 6, 2024
Merged

PEP 736: Final Draft #4145

merged 9 commits into from
Dec 6, 2024

Conversation

joshuabambrick
Copy link
Contributor

@joshuabambrick joshuabambrick commented Dec 2, 2024

@joshuabambrick joshuabambrick changed the title PEP 736 Final Draft PEP 736: Final Draft Dec 2, 2024
@joshuabambrick joshuabambrick marked this pull request as ready for review December 2, 2024 23:40
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another little nit, can update the case for these library names to:

Statistic                                                             `Polars <a_>`__ `FastAPI <b_>`__ `Rich <c_>`__ `HTTPX <d_>`__

peps/pep-0736.rst Outdated Show resolved Hide resolved
peps/pep-0736.rst Outdated Show resolved Hide resolved
@joshuabambrick
Copy link
Contributor Author

Comments addressed. This is ready to be merged.

@hugovk
Copy link
Member

hugovk commented Dec 6, 2024

@Rosuav Good to merge?

@Rosuav
Copy link
Contributor

Rosuav commented Dec 6, 2024

@Rosuav Good to merge?

LGTM!

@hugovk hugovk merged commit 96b7910 into python:main Dec 6, 2024
5 checks passed
@joshuabambrick joshuabambrick deleted the pep736-final branch December 6, 2024 22:18
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants