Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: let codespell run in parallel and output in order #4146

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 3, 2024

Send all the files to codespell so we get the output in codespell's alphabetical order.

require_serial: (optional: default false) if true this hook will execute using a single process instead of in parallel.

https://pre-commit.com/#hooks-require_serial

Before

make spellcheck
...
Check for common misspellings in text files..............................Failed
- hook id: codespell
- exit code: 65

peps/pep-0728.rst:381: overriden ==> overridden
peps/pep-0728.rst:676: othere ==> other
peps/pep-0739/python-build-info-v1.0.schema.json:267: Implamentations ==> Implementations
peps/pep-0747.rst:548: alowed ==> allowed
peps/pep-0777.rst:357: introducted ==> introduced
peps/pep-0757.rst:457: bufferes ==> buffers, buffered
peps/pep-0758.rst:60: paretheses ==> parentheses
peps/pep-0739.rst:48: feasable ==> feasible
peps/pep-0739.rst:694: Implamentations ==> Implementations
peps/pep-0751.rst:868: tread ==> thread, treat
peps/pep-0751.rst:1230: everytime ==> every time
peps/pep-0755.rst:267: mistakingly ==> mistakenly
peps/pep-0750.rst:1288: opportunty ==> opportunity

make: *** [spellcheck] Error 1

After

make spellcheck
...
Check for common misspellings in text files..............................Failed
- hook id: codespell
- exit code: 65

peps/pep-0728.rst:381: overriden ==> overridden
peps/pep-0728.rst:676: othere ==> other
peps/pep-0739.rst:48: feasable ==> feasible
peps/pep-0739.rst:694: Implamentations ==> Implementations
peps/pep-0739/python-build-info-v1.0.schema.json:267: Implamentations ==> Implementations
peps/pep-0747.rst:548: alowed ==> allowed
peps/pep-0750.rst:1288: opportunty ==> opportunity
peps/pep-0751.rst:868: tread ==> thread, treat
peps/pep-0751.rst:1230: everytime ==> every time
peps/pep-0755.rst:267: mistakingly ==> mistakenly
peps/pep-0757.rst:457: bufferes ==> buffers, buffered
peps/pep-0758.rst:60: paretheses ==> parentheses
peps/pep-0777.rst:357: introducted ==> introduced

make: *** [spellcheck] Error 1

📚 Documentation preview 📚: https://pep-previews--4146.org.readthedocs.build/

@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Dec 3, 2024
@hugovk hugovk requested a review from CAM-Gerlach as a code owner December 3, 2024 12:30
@hugovk hugovk merged commit d8194ab into python:main Dec 15, 2024
6 checks passed
@hugovk hugovk deleted the codespell-order branch December 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant