Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 768: Safe external debugger interface for CPython #4158

Merged
merged 18 commits into from
Dec 9, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 6, 2024

No description provided.

pablogsal and others added 4 commits November 27, 2024 13:25
Mostly minor nits, with a few sections reworded for clarity.

The switch to C99 compatible `//` comments instead of `/*` comments is
just because neovim's reST syntax highlighter is getting tripped up by
the code blocks and gets stuck thinking that the rest of the document is
emphasized.

Signed-off-by: Matt Wozniski <[email protected]>
@pablogsal pablogsal requested a review from a team as a code owner December 6, 2024 16:59
@pablogsal
Copy link
Member Author

CC: @godlygeek @ivonastojanovic

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds great! Just a few nits.

peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
pablogsal and others added 3 commits December 6, 2024 18:30
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to CODEOWNERS.

peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
peps/pep-0778.rst Outdated Show resolved Hide resolved
@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Dec 6, 2024
pablogsal and others added 9 commits December 7, 2024 00:24
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
peps/pep-0778.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk changed the title PEP 778: Safe external debugger interface for CPython PEP 768: Safe external debugger interface for CPython Dec 7, 2024
@pablogsal pablogsal enabled auto-merge (squash) December 9, 2024 00:18
@pablogsal pablogsal merged commit 24e078b into python:main Dec 9, 2024
4 of 5 checks passed
@pablogsal pablogsal deleted the debugger branch December 9, 2024 00:20
@pablogsal
Copy link
Member Author

Thanks a lot for your fantastic comments as always @JelleZijlstra @hugovk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants