PEP 728: Improve specification #4166
Open
+77
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify that extra_items and closed are also supported with the functional syntax. - Rewrite the rules for `closed=True` and inheritance. I attempted to make `closed=True` exactly equivalent to `extra_items=Never` in terms of inheritance. The semantics as specified in the previous version of the PEP felt harder to understand and less consistent. - Fix some incorrect comments regarding expected type checker errors. - Clarify section on assignability with Mapping - Add section on runtime behavior. I tried to make the intended runtime behavior simple to implement and understand. This makes the runtime simpler but may make life more complicated for tools consuming the metadata.
mnoori1201
approved these changes
Dec 13, 2024
PIG208
approved these changes
Dec 14, 2024
PIG208
approved these changes
Dec 15, 2024
rchen152
approved these changes
Dec 17, 2024
| adapted_from_novel: bool | ||
|
|
||
| class MovieRequiredYear(MovieBase): # Not OK. Required key 'year' is not known to 'Parent' |
There was a problem hiding this comment.
Suggested change
| class MovieRequiredYear(MovieBase): # Not OK. Required key 'year' is not known to 'Parent' | |
| class MovieRequiredYear(MovieBase): # Not OK. Required key 'year' is not known to 'MovieBase' |
| class AdaptedMovie(MovieBase): # Not OK. 'bool' is not assignable to 'int | None' | ||
|
|
||
| class AdaptedMovie(MovieBase): # Not OK. 'bool' is required |
There was a problem hiding this comment.
AdaptedMovie and MovieRequiredYear seem redundant with each other now. They're both examples of a required key.
| @@ -384,14 +396,14 @@ For example:: | |||
|
|
|||
There was a problem hiding this comment.
I know this is preexisting, but there's a typo three lines above (misspelling of overridden).
(Sadly, I can't comment on the exact line - https://github.com/orgs/community/discussions/4452.)
There was a problem hiding this comment.
And another:
❯ make spellcheck
...
peps/pep-0728.rst:393: overriden ==> overridden
peps/pep-0728.rst:706: othere ==> other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional syntax.
closed=Trueand inheritance. I attemptedto make
closed=Trueexactly equivalent toextra_items=Neverinterms of inheritance. The semantics as specified in the previous
version of the PEP felt harder to understand and less consistent.
behavior simple to implement and understand. This makes the runtime
simpler but may make life more complicated for tools consuming the
metadata.
This grew out of work on python/typing-extensions#519. cc @PIG208
📚 Documentation preview 📚: https://pep-previews--4166.org.readthedocs.build/