Log PT2 chromium events to scuba #2424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Summary: X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
force-pushed
the
export-D61392607
branch
from
1249d76
to
04c5382
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 19, 2024
Summary: X-link: pytorch/benchmark#2424 Pull Request resolved: #133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Test Plan: All of the above views are run with nanogpt benchmark: ``` buck run mode/opt caffe2/benchmarks/dynamo:torchbench -- --training --backend=inductor --only nanogpt --performance ``` Reviewed By: ezyang Differential Revision: D61392607
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
added a commit
that referenced
this pull request
Aug 19, 2024
Summary: Pull Request resolved: #2424 X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
jamesjwu
force-pushed
the
export-D61392607
branch
from
04c5382
to
abba6fd
Compare
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 19, 2024
Summary: X-link: pytorch/benchmark#2424 Pull Request resolved: #133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Test Plan: All of the above views are run with nanogpt benchmark: ``` buck run mode/opt caffe2/benchmarks/dynamo:torchbench -- --training --backend=inductor --only nanogpt --performance ``` Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/benchmark#2424 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Test Plan: All of the above views are run with nanogpt benchmark: ``` buck run mode/opt caffe2/benchmarks/dynamo:torchbench -- --training --backend=inductor --only nanogpt --performance ``` Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
force-pushed
the
export-D61392607
branch
from
abba6fd
to
139c7f1
Compare
facebook-github-bot
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
facebook-github-bot
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/benchmark#2424 Pull Request resolved: #133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Test Plan: All of the above views are run with nanogpt benchmark: ``` buck run mode/opt caffe2/benchmarks/dynamo:torchbench -- --training --backend=inductor --only nanogpt --performance ``` Reviewed By: ezyang Differential Revision: D61392607
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
added a commit
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: #2424 X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
jamesjwu
force-pushed
the
export-D61392607
branch
from
139c7f1
to
31e19f1
Compare
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
approved these changes
Aug 20, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
force-pushed
the
export-D61392607
branch
from
31e19f1
to
1cd7776
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
force-pushed
the
export-D61392607
branch
from
1cd7776
to
14b2d39
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Summary: X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
facebook-github-bot
force-pushed
the
export-D61392607
branch
from
14b2d39
to
ec3ec05
Compare
facebook-github-bot
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
facebook-github-bot
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
added a commit
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: #2424 X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
jamesjwu
force-pushed
the
export-D61392607
branch
from
ec3ec05
to
a4b4503
Compare
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Summary: Pull Request resolved: #2424 X-link: pytorch/pytorch#133859 This diff implements a bunch of views for internal scuba viewing. TODOS that I might punt to another diff: - Saving cache stats via counter is definitely sus here, but there's not really a good way to track "fx graph cache hit for this compile phase" right now. Will think about this more. - We should definitely log frame id, compile id, etc - We should definitely be logging configs. That way, we can A/B test based on whether a config is turned on. - idk what I'm doing with compile_uuid yet, but it's useful when you want to look at samples for a single run. I think if we had mast job info this field is not needed, but it's nice to be able to drill down to a single run and get its chrome trace view or icicle view, so idk Reviewed By: ezyang Differential Revision: D61392607
|
This pull request was exported from Phabricator. Differential Revision: D61392607 |
jamesjwu
force-pushed
the
export-D61392607
branch
from
a4b4503
to
83dd4f4
Compare
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jamesjwu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#133859
This diff implements a bunch of views for internal scuba viewing.
TODOS that I might punt to another diff:
Differential Revision: D61392607