Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace decoder with self.decoder in PyTorch Chatbot example. #3090

Merged
merged 3 commits into from
Dec 2, 2024
Merged

replace decoder with self.decoder in PyTorch Chatbot example. #3090

merged 3 commits into from
Dec 2, 2024

Conversation

Ishan-Kumar2
Copy link
Contributor

@Ishan-Kumar2 Ishan-Kumar2 commented Oct 13, 2024 •
edited by pytorch-bot bot
Loading

Description

The decoder function needs to use self.decoder else it will throw a decoder not defined error.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @albanD @jbschlosser

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 521bdc4 with merge base 1428770 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Oct 14, 2024
albanD
albanD approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svekars svekars merged commit f2d5a6a into pytorch:main Dec 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ishan-Kumar2 @albanD @svekars @facebook-github-bot