Add last verified script #3154
Add last verified script #3154
Conversation
svekars
commented
Nov 8, 2024
•
svekars
commented
- Add a script that inserts Created On, Last Updated On, Verified On after the title in the tutorials
- The .json with the tutorials audit data that is used for last verified is stored in the "last-reviewed-data-json" branch and downloaded via a new Makefile command
- Modified the GH tutorilas-build workflow to fetch all log history.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3154
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 137f995 with merge base 3ba3a46 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Delete the JSON from the main branch
| @@ -44,6 +44,8 @@ jobs: | |||
| - name: Checkout Tutorials | |||
| uses: actions/checkout@v3 | |||
| with: | |||
There was a problem hiding this comment.
This could be done in separate PR
There was a problem hiding this comment.
I need this to get the git history so that the Created On data is added correctly
| @@ -0,0 +1,12 @@ | |||
| :orphan: | |||
There was a problem hiding this comment.
How is this unrelated to PR in question?
beginner_source/t5_tutorial.rst
Outdated
| @@ -1,3 +1,5 @@ | |||
| :orphan: | |||
| @@ -1,3 +1,5 @@ | |||
| :orphan: | |||
| from bs4 import BeautifulSoup | ||
|
|
||
| # Check if the build directory is provided as an argument in the Makefile | ||
| if len(sys.argv) < 2: |
There was a problem hiding this comment.
Please follow __main__ code pattern: https://docs.python.org/3/library/__main__.html
| def get_creation_date(file_path): | ||
| try: | ||
| result = subprocess.run( | ||
| ["git", "log", "--diff-filter=A", "--format=%aD", "--", file_path], | ||
| capture_output=True, | ||
| text=True, | ||
| check=True, | ||
| ) | ||
| if result.stdout: | ||
| creation_date = result.stdout.splitlines()[0] | ||
| creation_date = datetime.strptime(creation_date, "%a, %d %b %Y %H:%M:%S %z") | ||
| formatted_date = creation_date.strftime("%b %d, %Y") | ||
| else: | ||
| formatted_date = "Unknown" | ||
| return formatted_date | ||
| except subprocess.CalledProcessError: | ||
| return "Unknown" |
There was a problem hiding this comment.
It feels like get_last_updated and get_created could benefit from some refactoring of common code.
And why unknown is an accepted answer? Shouldn't it raise an exception that should be handled elsewhere?
