Update gitignore to ignore build artificats #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
reviewed
Oct 9, 2024
| /data | ||
| .vscode | ||
| app |
There was a problem hiding this comment.
That's the built binary, should be ignored in my opinion
| .vscode | ||
| app | ||
| cmd/ddns-updater/data/ |
There was a problem hiding this comment.
Why would the data directory be in cmd/ddns-updater/data/?
On my side, I usually build and run from the root of the workspace with go run ./cmd/ddns-updater/main.go and it picks up the data directory there.
There was a problem hiding this comment.
It should be ignored because while developing you would probably add your ddns secrets in there which would then be leaked if pushed
qdm12
force-pushed
the
master
branch
2 times, most recently
from
126315b
to
691ed32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.