-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add type, format, transformer info to plugin pages #435
Closed
Oddant1
wants to merge
13
commits into
qiime2:master
from
Oddant1:Add-type-format-transformer-info-to-plugin-pages
+167
−2
Closed
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e1f4859
NEW: Add type, format, transformer info to plugin pages
Oddant1 ef5ce7c
NEW: Add type, format, transformer info to plugin pages
Oddant1 7029261
Add ChrisKeefe as co-author
Oddant1 f37de71
Add ChrisKeefe as co-author
Oddant1 f13bc64
SQUASH: Fix some issues with python built-ins displaying and sorting
Oddant1 4fbef31
Merge branch 'Add-type-format-transformer-info-to-plugin-pages' of ht…
Oddant1 59d180a
SQUASH: Addressing @thermokarst's review
Oddant1 7d0436e
SQUASH: Begin moving the types, formats, and transformers pages to a …
Oddant1 b9a5f90
SQUASH: Reformat types/formats/transformers pages
Oddant1 971b3d0
SQUASH: Some reworking of the types, formats, and transformers
Oddant1 5103bc8
SQUASH: Fix warning and strange transformers
Oddant1 3675e78
SQUASH: add .upper() back to transformer sorting to ensure proper order
Oddant1 2871dbc
SQUASH: Slight refactor
Oddant1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBC:
Please see this PEP for a simpler way to do this: https://www.python.org/dev/peps/pep-3155/
An example in QIIME 2 can be found here: https://github.com/qiime2/qiime2/blob/46541f547c92714079dbd0342e10a85b74522305/qiime2/core/util.py#L28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, you might just want to look at using
get_view_name
, outright.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use
get_view_name
outright, we will probably need to open a tiny PR on the framework to expose that util throughsdk
(right now it is only incore
).