-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composer-dependency-analyser (fix shadow dependencies) #1374
Add composer-dependency-analyser (fix shadow dependencies) #1374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you are right, I found the tool last week and thinking the same.
The failed CI job looks like a bug, reported here: IonBazan/composer-diff#30 |
024da5a
to
42c8d06
Compare
I tried fixing the issue as suggested in the bugreport, but as I'm just sending fork, GitHub security measures are not executing the new job (when So in order to unblock this PR, some maintainer need to adjust the broken job. Note: I removed my commit that attempted to fix it. |
The bug should be solvable just by bumping the version: diff --git a/.github/workflows/composer-diff.yml b/.github/workflows/composer-diff.yml
index 3bfdb4fc..f5748bdc 100644
--- a/.github/workflows/composer-diff.yml
+++ b/.github/workflows/composer-diff.yml
@@ -19,6 +19,6 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0
- name: Comment composer.lock diff
- uses: WyriHaximus/github-action-composer.lock-diff@v1
+ uses: WyriHaximus/github-action-composer.lock-diff@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} But as said above, I cannot do it in PR due to security measures of GitHub. |
74f76fa
to
42c8d06
Compare
@janedbal could you fix the conflict? |
42c8d06
to
d26eb68
Compare
Fixed conflict |
@janedbal thank you for your contribution. |
Hi, I tested your repository with composer-dependency-analyser and it found some shadow dependencies:
All those seem valid to me, so I added those to composer and the tool to CI to avoid possible issues in future.