Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: seperate line output when a release is missing changelog #1302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: seperate line output when a release is missing changelog #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/prepare-release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ done
shift $((OPTIND - 1))
VERSION="${1:?need a version argument}"
VERSION="v${VERSION#v}"

IFS=
Copy link
Member

@hdonnay hdonnay Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest something like:

gh search prs --state closed --merged --label=needs-changelog --json=title,url | jq -r '.[] | (.url | @text) + " - " + (.title | @text)' > /tmp/prs
if [ -s /tmp/prs ]; then
    echo "There are still PRs that need changelog entries"
    cat /tmp/prs
    exit 1
fi

prs=$(gh search prs --repo $GH_REPO --state closed --merged --label=needs-changelog --json=title,url | jq -r '.[] | (.url | @text) + " - " + (.title | @text)')
if [ -n "$prs" ]
then
Expand Down
Loading