This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
settings: Add organization and user settings (PROJQUAY-4553) #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathankingfc
commented
Jan 24, 2023
jonathankingfc
commented
- This PR includes a few features that enhance the org/settings customization flows
- Users can now convert their account from individual to organization
- Users can update their e-mail and other similar metadata regarding their account
- Error handling has been added to the settings pages / clear back to defaults
- Added ability to generate CLI token for user account
- This PR includes a few features that enhance the org/settings customization flows - Users can now convert their account from individual to organization - Users can update their e-mail and other similar metadata regarding their account - Error handling has been added to the settings pages / clear back to defaults - Added ability to generate CLI token for user account
harishsurf
reviewed
Jan 31, 2023
| @@ -16,6 +16,8 @@ import { | |||
| import {useLocation} from 'react-router-dom'; | |||
| import {useCurrentUser} from 'src/hooks/UseCurrentUser'; | |||
| import {useOrganization} from 'src/hooks/UseOrganization'; | |||
| import {BillingInformation} from './BillingInformation'; | |||
| import {CliConfiguration} from './CLIConfiguration'; | |||
|
|
|||
| const GeneralSettings = () => { | |||
There was a problem hiding this comment.
I see this variable defined in GeneralSettings.tsx and one of it doesn't seem to be referenced anywhere. Could you take a look?
| View Invoices | ||
| </Button> | ||
|
|
||
| {isUserOrganization && ( |
There was a problem hiding this comment.
I am unable to see this additional settings field for a user
harishsurf
reviewed
Jan 31, 2023
| </HelperText> | ||
| <FormGroup | ||
| isInline | ||
| label="Admin Username" |
There was a problem hiding this comment.
nit: mocks show this to just Username
| </FormGroup> | ||
| <FormGroup | ||
| isInline | ||
| label="Admin Username" |
There was a problem hiding this comment.
label would be password
| <Tbody> | ||
| {paginatedBulkItemsList.map((item, idx) => ( | ||
| <Tr key={idx}> | ||
| <Td>{item.name}</Td> |
There was a problem hiding this comment.
The mock shows the org names to be clickable
| import {GenerateEncryptedPassword} from 'src/components/modals/GenerateEncryptedPasswordModal'; | ||
| import {useState} from 'react'; | ||
|
|
||
| export const CliConfiguration = () => { |
There was a problem hiding this comment.
This doesn't seem to be called anywhere?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.