These tests do more harm than good #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2477 As written, these tests (indirectly) call `remotes::update_packages("roxygen2")` which can cause package installation on any machine that runs the tests. And this installation is NOT scoped correctly, i.e. to a temporary library. I got fairly far into refactoring the tests, when I realized that fixing them introduced more complexity than was worth it. Passing arguments along isn't a tricky operation. devtools is better off without these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2477
As written, these tests (indirectly) call
remotes::update_packages("roxygen2")which can cause package installation on any machine that runs the tests. And this installation is NOT scoped correctly, i.e. to a temporary library.I got fairly far into refactoring the tests, when I realized that fixing them introduced more complexity than was worth it. Passing arguments along isn't a tricky operation. devtools is better off without these tests.