Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(host_groups): vm-2001 and vm-2002 hostgroup added with parameters required by the vm #179

Merged
merged 10 commits into from
Dec 19, 2024
Merged

feat(host_groups): vm-2001 and vm-2002 hostgroup added with parameters required by the vm #179

merged 10 commits into from
Dec 19, 2024

Conversation

smirta
Copy link
Member

@smirta smirta commented Nov 24, 2024 •
edited by hairmare
Loading

No description provided.

@smirta smirta requested a review from hairmare November 24, 2024 22:32
@smirta smirta self-assigned this Nov 24, 2024
hairmare
hairmare reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to apply the AlmaLinux 9.5 update via this change:

roles/foreman/tasks/host_groups.yaml Outdated Show resolved Hide resolved
roles/foreman/tasks/host_groups.yaml Outdated Show resolved Hide resolved
hairmare
hairmare reviewed Dec 1, 2024
View reviewed changes
Copy link
Member

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't parent be on a single line?

roles/foreman/tasks/host_groups.yaml Outdated Show resolved Hide resolved
roles/foreman/tasks/host_groups.yaml Outdated Show resolved Hide resolved
@hairmare hairmare changed the title feat(host_groups): vm-2001 and vm-2002 hostgroup added with parameter… feat(host_groups): vm-2001 and vm-2002 hostgroup added with parameters required by the vm Dec 19, 2024
@hairmare hairmare merged commit b4f98ee into main Dec 19, 2024
1 check passed
@hairmare hairmare deleted the feat/add-vm-2001-and-vm-2002-host-groups branch December 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare left review comments

Assignees

@smirta smirta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smirta @hairmare