feat: bump go to 1.15 and update deps #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modern go has some patches pertaining to loosing connections that might help anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern go has some patches pertaining to loosing connections that might help with #21
Quite possibly I'll also have to add a kind of keepalive but SAPv2 does not seem to have any noop things I can do for that. This doesn't include any keepaliving since I'm not conviced that it's the right way to go and I'd like to check if updating all our deps helps get better error message when the case described in #21 which I can only really reproduce on prod happens.
This update makes sense in any case though (even if it doesn't end up fixing #21).