Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Create continuous integration and deployment pipelines #5

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Nov 19, 2024

  • Run next lint on pull requests
  • Publish container images to ghcr.io based on rabe actions.

@hairmare hairmare force-pushed the chore/ci-configuration branch 5 times, most recently from e26e5a7 to e2e6c8b Compare November 19, 2024 21:27
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@hairmare hairmare force-pushed the chore/ci-configuration branch from e2e6c8b to 161c52c Compare November 19, 2024 21:35
Comment on lines +24 to +27
# defaults for use during the container build phase on CI/CD
ARG IMAGES_PROTOCOL=https
ARG IMAGES_HOSTNAME=**
ARG IMAGES_PORT=433
Copy link
Member Author

@hairmare hairmare Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to revisit this change before considering this PR ready.

Setting the hostname to ** is most likely a security issue, but we do want to allow several hostnames so we can use the same CI built image without having it be rebuilt for each hostname. The patterm *.rabe.ch might fulfill this, or we add a regex that is more specific.

Potentially we could go even further and also add pathname to narrow down the allowed image URLs.

Note to self: the docs for the feature are here: https://nextjs.org/docs/pages/api-reference/components/image#remotepatterns (and the env vars are defined in next.config.js).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to *.rabe.ch during build-time in the CI pipeline, but that pattern still allows sites like share.rabe.ch.

Preferably we would like for it to not be possible to optimize content from ownCloud via nextjs.

@hairmare hairmare force-pushed the chore/ci-configuration branch 5 times, most recently from b3f2583 to 900db84 Compare November 24, 2024 13:45
@hairmare hairmare force-pushed the chore/ci-configuration branch 3 times, most recently from 1f2268c to ee61e96 Compare December 2, 2024 15:52
@hairmare hairmare force-pushed the chore/ci-configuration branch 2 times, most recently from 84c4c0e to f85708b Compare December 9, 2024 13:25
@hairmare hairmare force-pushed the chore/ci-configuration branch 12 times, most recently from 24800bc to fc91cc3 Compare December 19, 2024 16:01
@hairmare hairmare force-pushed the chore/ci-configuration branch 2 times, most recently from 9744e87 to 234a2b8 Compare December 19, 2024 16:33
@hairmare hairmare changed the title chore(ci): Publish container images to ghcr.io chore(ci): Create continuous integration and deployment pipelines Dec 19, 2024
@hairmare hairmare force-pushed the chore/ci-configuration branch 2 times, most recently from 664be2f to c00802b Compare December 19, 2024 17:14
* Run `next lint` on pull requests
* Publish container images to ghcr.io
@hairmare hairmare force-pushed the chore/ci-configuration branch from c00802b to 9bcc5cf Compare December 20, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant