-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify tooltip positioning and tooltip triangle pointer positioning #1805
base: master
Are you sure you want to change the base?
Conversation
Have you tested the fix I've pushed? Your changes might affect drastically all components that are using popups - DataGrid, ContextMenu, DropDown/DropDownDataGrid, DatePicker, AutoComplete, etc. |
Did not know how to build for Material-base3. So try it in default theme or any free theme i assume. Edit: Edit 2: |
…to be in this if-statement.
After commit, i have tested all the popups i know of and they seem to be working now. They work like they use to (still smartPositions on both y- and x-axis when needed to. Aand only tooltips behave in a way of the new code. But then again i know it is changing some fundamental code for all popups and there might be unforseen bugs. So understand why this might not be a viable solution. Edit: |
tooltip-content
css-class solely in javascript methodopenPopup()
.I made this solution before Commit a0f1545 ("Tooltip position updated when forced to change"), so unfortunately i have not implemented that current fix/solution. However i dont see the need for that with this current code.
Have tested DateGrid/Chart popups too and have tried to avoid configuring theese as much as possible.
The "reset" logic of removing all css-classes before adding new might be able to be done more cleanly.