Update shaders_basic_pbr example to work on web #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbr implementation includes rpbr.h and few shader files header only file, which self contain everything needed for pbr rendering. Few textures and one model of the car which is under free licence which is included inside basic_pbr.c example file currently supported shader versions are 120 and 330 , version 100 has small issue which I have to resolve
I forgot unloading PBRMaterial
value was Vector4 at first but I found out it would be unclear for and users, so I change to have two Vector2 instead, but forgot to assign offset .
Changed size of textures from 2048x2048 to 1024x1024 and file name changed to shaders_basic_pbr.c , Added the function PBRModel PBRModelLoadFromMesh(Mesh mesh); but GenMeshPlane(2, 2.0, 3, 3) culdn't be used because it crash once GenMeshTangents() is used with that plane mesh
set GLSL_VERSION 100 set precision highp float; removed in keyword fix for loop has to use only constant
changed to GLSL_VERSION 100 update glsl100 shader set float precision to highp removed keyword in change for loop tu use constant value gives an error
changed to GLSL_VERSION 100 update glsl100 shader set float precision to highp removed keyword in change for loop tu use constant value gives an error
|
@devdad afair, |
|
I am sorry for the mess only 69f1ab8 is relevant rpbr.h , ah I forgot to remove it from my fork. |
|
@devdad I think you can remove it with a PR added |
|
ok I will
…On Tue, Nov 19, 2024 at 10:40 PM Ray ***@***.***> wrote:
@devdad <https://github.com/devdad> I think you can remove it with a PR
added
—
Reply to this email directly, view it on GitHub
<#4516 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4ZOQKKJOR6CVWMSU6T2ND2BOV6PAVCNFSM6AAAAABSCUCDCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWHAYDQMZTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
removed rpbr.h
|
ok done removed ! |
|
@devdad Nice! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only two file changed are
examples/shaders/shaders_basic_pbr.c
examples/shaders/resources/shaders/glsl100/pbr.fs