[rcore] [SDL2] Fix maximizing, minimizing and restoring windows #4607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
RestoreWindow()
(ref) forPLATFORM_DESKTOP_SDL
that was using the incorrect call.Fixes manually minimizing, maximizing and restoring the window not setting the correct
FLAG_WINDOW_MAXIMIZED
andFLAG_WINDOW_MINIMIZED
respectively onPLATFORM_DESKTOP_SDL
, andIsWindowMinimized()
(ref) andIsWindowMaximized()
(ref) that were INOP onPLATFORM_DESKTOP_SDL
because the platform was missing event handling forSDL_WINDOWEVENT_MINIMIZED
,SDL_WINDOWEVENT_MAXIMIZED
andSDL_WINDOWEVENT_RESTORED
(ref, ref). Manual detection to check if the window was maximized was necessary due toSDL2
restore being unreliable on some platforms (ref).This PR was tested with
SDL2.30.10
onLinux Mind 22.0
.SDL3
wasn't tested but left placeholders for it and probably should work ifSDL_WINDOW_MAXIMIZED
was fixed there.The PR can be tested with: