Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sound driver based on virtio v1.2. #137

Merged
merged 78 commits into from
Jul 29, 2024
Merged

Added sound driver based on virtio v1.2. #137

merged 78 commits into from
Jul 29, 2024

Conversation

muxinyu1
Copy link
Contributor

@muxinyu1 muxinyu1 commented Jun 3, 2024

  • Only the output stream has been implemented.
  • Two audio playback modes have been implemented: synchronous blocking and asynchronous non-blocking.
  • Tested successfully on Ubuntu 22.04 LTS.

muxinyu1 and others added 30 commits April 26, 2024 23:58
@muxinyu1
Add more traits for struct ReadOnly, etc.
9ebda13
@muxinyu1
Add virtio sound driver, and its basic configurations are finished.
5574b97
@muxinyu1
Implemented item information request.
e96533f
@muxinyu1
Implemented available_jacks(), but left some errors.
bc59270
@muxinyu1
Add some test code.
18adfec
@muxinyu1
Implemented pcm_set_params.
3340ab6
@muxinyu1
Implemented the operations which are in different pcm stages.
927d6c3
@muxinyu1
Configured the sound device correctly.
531d232
@muxinyu1
Add test code.
48b32ce
@muxinyu1
Implemented all methods except I/O transfer.
07b7dc8
@muxinyu1
Implemented some PCM methods.
03ae7a3
@muxinyu1
Add test code.
df95710
@muxinyu1
Fixed bugs.
8f78ee5
@muxinyu1
Changed music size to be played.
ecb57c7
@muxinyu1
Added error processing code.
40340bf
@muxinyu1
Removed useless comments.
11f2811
@muxinyu1
Implemented chmap infos.
01619b3
@muxinyu1
Implemented notifications.
5e2004b
@muxinyu1
Implemented the sync version.
5ff955b
@muxinyu1
Try xfer twice.
55cec61
@muxinyu1
Implemented pcm_xfer_with_buffer_size().
54318b0
@muxinyu1
Add music Nocturne(夜曲 in Chinese).
86044f5
@muxinyu1
Fixed pcm xfer bugs.
cef931e
@muxinyu1
Improved the smoothness of audio playback and fixed the pause bug dur…
f4d762d 
…ing playback.
@muxinyu1
Added stop, release code.
4c3759c
@muxinyu1
Simplified code.
8764b15
@muxinyu1
Fixed bugs.
d868645
@muxinyu1
Increased buffer_bytes.
05f2ff0
@muxinyu1
Added non-blocking method.
7fca8ba
@muxinyu1
Replaced test music.
cd50590
@muxinyu1
Copy link
Contributor Author

Thank you very much for your help on my PR! If there is anything where I can help, I will do my best to provide assistance!

qwandor added 5 commits July 29, 2024 13:58
@qwandor
Unit test playing sound.
aa59323
@qwandor
Use add_notify_wait_pop when relevant.
addb26b
@qwandor
Validate buffer_bytes and period_bytes.
c21497b
@qwandor
Make fake_read_write_queue return whether queue had anything available.
6720108 
This allows it to be repeated if necessary, as there may be a single
notification for several items in the queue.
@qwandor
Re-write pcm_xfer.
26fa867 
It had some lifetime issues, and didn't work properly when called more
than once. The new version is also much shorter and easier to
understand.
@qwandor qwandor merged commit a86f69c into rcore-os:master Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwandor qwandor qwandor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muxinyu1 @qwandor