Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macro to read config fields #171

Closed
wants to merge 1 commit into from
Closed

add macro to read config fields #171

wants to merge 1 commit into from

Conversation

fkm3
Copy link
Contributor

@fkm3 fkm3 commented Dec 3, 2024

Ensures that the offset and type match.

Proof of concept of #163 (comment)

This doesn't mesh well with the existing config struct definitions, which use
types to specify qualities like "read only" and "volatile". Since
#163, it seems like those are
essentially ignored, so, if this macro seems like a good idea, it would
probably make sense to change the config types to be plain-old-data struct that
implement zerocopy traits.

Ensures that the offset and type match.
@qwandor
Copy link
Collaborator

qwandor commented Dec 4, 2024

What do you think of the approach in #170?

@fkm3
Copy link
Contributor Author

fkm3 commented Dec 4, 2024

looks good, closing this one

@fkm3 fkm3 closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants