Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: father4 & rc-test #350

Merged
merged 3 commits into from
Mar 1, 2023
Merged

chore: father4 & rc-test #350

merged 3 commits into from
Mar 1, 2023

Conversation

MuxinFeng
Copy link
Contributor

relate #349

@vercel
Copy link

vercel bot commented Feb 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dialog ❌ Failed (Inspect) Mar 1, 2023 at 6:35AM (UTC)

@MuxinFeng MuxinFeng mentioned this pull request Feb 28, 2023
Merged
@MadCcc
Copy link
Member

MadCcc commented Feb 28, 2023

单测挂了

@MuxinFeng
Copy link
Contributor Author

单测挂了

好滴，我看下

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #350 (f8742f3) into master (fd1e6f1) will decrease coverage by 0.63%.
The diff coverage is n/a.

❗ Current head f8742f3 differs from pull request most recent head 5cdbb25. Consider uploading reports for the commit 5cdbb25 to get more accurate results

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   98.73%   98.11%   -0.63%     
==========================================
  Files           7        7              
  Lines         158      159       +1     
  Branches       49       50       +1     
==========================================
  Hits          156      156              
- Misses          1        2       +1     
  Partials        1        1
Impacted Files Coverage Δ
src/Dialog/index.tsx 98.50% <0.00%> (-1.50%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MadCcc MadCcc merged commit b666e19 into react-component:master Mar 1, 2023
@MuxinFeng
Copy link
Contributor Author

感谢大佬，学到了~

afc163
afc163 reviewed Mar 14, 2023
View reviewed changes
tests/index.spec.tsx
it('support input autoFocus', () => {
const wrapper = mount(
// 失效了，需要修复
it.skip('support input autoFocus', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看上去得修一下 ant-design/ant-design#41239

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考 259f3cd 这个修复。之前是修复过的，后面改丢了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好滴

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前还是没啥思路，可能需要其他大佬来看看了。

@acyza acyza mentioned this pull request Mar 20, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MuxinFeng @MadCcc @afc163