Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: BaseInput #55

Merged
merged 1 commit into from
Dec 14, 2023
Merged

refactor: BaseInput #55

merged 1 commit into from
Dec 14, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 14, 2023

  • affix-wrapper 上添加 ${prefix}-disabled className,简化使用
  • 完全废弃 classes,所有属性移到 classNames
  • 废弃 inputElement,使用 children 代替
  • className stylehidden 属性现在会在最后附加到返回的元素上,移除复杂的判断逻辑
  • 一些 BaseInput 的结构优化

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d75e44d) 96.80% compared to head (447ae1d) 96.72%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   96.80%   96.72%   -0.09%     
==========================================
  Files           5        5              
  Lines         188      183       -5     
  Branches       72       69       -3     
==========================================
- Hits          182      177       -5     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 063185a into master Dec 14, 2023
8 of 9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/BaseInput branch December 14, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant