Fix floating-point arithmetic issues when props are decimals. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2020 13:32
jcfrancisco
commented
Jan 21, 2020
Comment on lines
+24
to
+31
| export function getPrecision(step) { | ||
| const stepString = step.toString(); | ||
| let precision = 0; | ||
| if (stepString.indexOf('.') >= 0) { | ||
| precision = stepString.length - stepString.indexOf('.') - 1; | ||
| } | ||
| return precision; | ||
| } |
There was a problem hiding this comment.
This function is untouched, moved it up because I'm using it elsewhere.
jcfrancisco
commented
Jan 21, 2020
Comment on lines
-73
to
+98
| parseFloat(closestPoint.toFixed(getPrecision(step))); | ||
| withPrecision(closestPoint, getPrecision(step)); |
There was a problem hiding this comment.
I can back out this refactor if it's unwanted
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 95.4% 95.83% +0.43%
==========================================
Files 2 2
Lines 87 96 +9
Branches 29 30 +1
==========================================
+ Hits 83 92 +9
Misses 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following case:
I would expect the output of
getClosestPointto be5.3. However, it returns5.25.This is because of floating point arithmetic issues with the function.
I've added a test case and taken a stab at figuring it out, making sure I continue to respect the
Math.floorlogic onmaxSteps.