Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance scrollTo ts type #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nuintun
Copy link

@nuintun nuintun commented Dec 8, 2020

// When not argument provided, we think dev may want to show the scrollbar
if (arg === null || arg === undefined) {
triggerFlash();
return;
}

@vercel
Copy link

vercel bot commented Dec 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/virtual-list/et0v166me
✅ Preview: https://virtual-list-git-patch-1.react-component.now.sh

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #91 (113f8e8) into master (d2bc792) will not change coverage.
The diff coverage is n/a.

❗ Current head 113f8e8 differs from pull request most recent head 94f615c. Consider uploading reports for the commit 94f615c to get more accurate results

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          480       470   -10     
  Branches        91        89    -2     
=========================================
- Hits           480       470   -10     
Impacted Files Coverage Δ
src/List.tsx 100.00% <ø> (ø)
src/mock.tsx 100.00% <0.00%> (ø)
src/ScrollBar.tsx 100.00% <0.00%> (ø)
src/utils/CacheMap.ts 100.00% <0.00%> (ø)
src/hooks/useHeights.tsx 100.00% <0.00%> (ø)
src/hooks/useMobileTouchMove.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
virtual-list ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 1:04AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant