Merge pull request #82 from maxkorp/samesite-cookies-none

Add explicit None option to SameSite cookies
reasonml-community · Oct 8, 2020 · d1b4ea5 · d1b4ea5
2 parents a656eb8 + 233a50c
commit d1b4ea5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Express.re b/src/Express.re
@@ -278,7 +278,7 @@ module Response = {
   [@bs.send.pipe: t]
   external clearCookie_ : (string, 'a) => unit = "clearCookie";
   [@bs.deriving jsConverter]
-  type sameSite = [ | [@bs.as "lax"] `Lax | [@bs.as "strict"] `Strict];
+  type sameSite = [ | [@bs.as "lax"] `Lax | [@bs.as "strict"] `Strict | [@bs.as "none"] `None];
   external toDict : 'a => Js.Dict.t(Js.nullable('b)) = "%identity";
   let filterKeys = obj => {
     let result = toDict(obj);

diff --git a/src/Express.rei b/src/Express.rei
@@ -219,7 +219,7 @@ module Response: {
       ~secure: bool=?,
       ~signed: bool=?,
       ~path: string=?,
-      ~sameSite: [ | `Lax | `Strict]=?,
+      ~sameSite: [ | `Lax | `Strict | `None]=?,
       ~domain: string=?,
       Js.Json.t,
       t
@@ -236,7 +236,7 @@ module Response: {
       ~secure: bool=?,
       ~signed: bool=?,
       ~path: string=?,
-      ~sameSite: [ | `Lax | `Strict]=?,
+      ~sameSite: [ | `Lax | `Strict | `None]=?,
       t
     ) =>
     t;