Generates VolRepClasses based on the RamenDR replication schedule resource #177
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raaizik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
raaizik
changed the title
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
597255c
to
7a6fc7b
Compare
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
626d539
to
f0ceee7
Compare
raaizik
force-pushed
the
RHSTOR-5753
branch
3 times, most recently
from
08910fd
to
8ee12ce
Compare
raaizik
changed the title
VolRepClass based on the RamenDR replication schedule resource
raaizik
force-pushed
the
RHSTOR-5753
branch
3 times, most recently
from
66dca4f
to
27ee9da
Compare
raaizik
changed the title
VolRepClass based on the RamenDR replication schedule resource
|
Depends on #2727 |
| } | ||
| // check if DRClusterConfig has been removed | ||
| if len(drclusterconfigs.Items) == 0 { | ||
| vrcs := &replicationv1alpha1.VolumeReplicationClassList{} |
There was a problem hiding this comment.
just set the owneRef of VolumeReplicationClass as the drclusterconfig as both are clusterscoped resouces?
| } | ||
| } | ||
| drclusterconfig := &drclusterconfigs.Items[0] | ||
| for interval := range drclusterconfig.Spec.ReplicationSchedules { |
There was a problem hiding this comment.
what will happen when specific ReplicationSchedules are deleted?
There was a problem hiding this comment.
Missed that, added ✔️
raaizik
force-pushed
the
RHSTOR-5753
branch
2 times, most recently
from
0b2bdcd
to
203fc57
Compare
| if err != nil { | ||
| return reconcile.Result{}, fmt.Errorf("failed to get VolumeReplicationClassList: %v", err) | ||
| } | ||
| drclusterconfig := &drclusterconfigs.Items[0] |
There was a problem hiding this comment.
This will fail if the len(drclusterconfigs.Items) is zero
| @@ -141,8 +192,9 @@ func (r *StorageClaimReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| //+kubebuilder:rbac:groups=snapshot.storage.k8s.io,resources=volumesnapshotclasses,verbs=get;list;watch;create;delete | |||
| //+kubebuilder:rbac:groups=core,resources=persistentvolumes,verbs=get;list;watch | |||
| //+kubebuilder:rbac:groups=snapshot.storage.k8s.io,resources=volumesnapshotcontents,verbs=get;list;watch | |||
| //+kubebuilder:rbac:groups=ramendr.openshift.io,resources=drclusterconfigs,verbs=get;list;watch | |||
| //+kubebuilder:rbac:groups=replication.storage.openshift.io,resources=volumereplicationclass,verbs=get;list;watch;create;delete | |||
There was a problem hiding this comment.
did you run make bundle after updating the rbac?
| if len(drclusterconfigs.Items) == 0 { | ||
| return reconcile.Result{}, fmt.Errorf("no DRClusterConfig found") | ||
| } |
There was a problem hiding this comment.
This is not an error, it means that we don't need to create VRC.
- Creates VolRepClass in response to changes made to DRClusterConfig - k8s csi addons bump Signed-off-by: raaizik <[email protected]>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changess
VolumeReplicationClassin response to changes made toDRClusterConfig-- the RamenDR replication schedule CR. VRCs are generated per each sched interval detailed inDRClusterConfig, for both flatten and non-flatten mode VRC types.RHSTOR-5753