Improve CJK links support (#57)

refined-github · Aug 26, 2024 · 6b702d0 · 6b702d0
1 parent 301a6c3
commit 6b702d0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -176,7 +176,13 @@ function shortenRepoUrl(href, currentUrl = 'https://github.com') {
 
 		cleanHref.push(parsedUrl.hash);
 
-		return cleanHref.join('');
+		// The user prefers seeing the URL as it was typed, so we need to decode it
+		try {
+			return decodeURI(cleanHref.join(''));
+		} catch {
+			// Decoding fails if the URL includes '%%'
+			return href;
+		}
 	}
 
 	if (user && !repo) {

diff --git a/index.test.js b/index.test.js
@@ -535,6 +535,10 @@ test('External URLs', urlMatcherMacro, new Map([
 		'https://example.com/nodejs/node/blob/cc8fc46/.gitignore',
 		'example.com/nodejs/node/blob/cc8fc46/.gitignore',
 	],
+	[
+		'https://example.site/한글로-된-URL',
+		'example.site/한글로-된-URL',
+	],
 ]));
 
 test('applyToLink', t => {