-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for https://github.com
exception
#64
Conversation
As you can see if url is Lines 274 to 276 in ce4fcc4
|
If we get the pathname is Lines 159 to 178 in ce4fcc4
so we will get a cleanHref that is |
@fregante Please review ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! I broke this in b1232be
(#61)
Can you add a test? Make sure it fails without this change
https://github.com
exception
@fregante Should I merge this? I think you forget this. |
I thought I commented 😅 yes you can. Also a new patch version can be released |
Test URL:
download-directory/download-directory.github.io#143