Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect logic for error handling #72

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: incorrect logic for error handling #72

merged 1 commit into from
Jun 24, 2024

Conversation

gaukas
Copy link
Contributor

@gaukas gaukas commented Jun 24, 2024

Fix #71.

@gaukas gaukas added the bug Something isn't working label Jun 24, 2024
@gaukas gaukas self-assigned this Jun 24, 2024
@gaukas gaukas requested a review from erikziyunchi as a code owner June 24, 2024 09:46
erikziyunchi
erikziyunchi approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this!

@gaukas gaukas merged commit 8979246 into master Jun 24, 2024
15 checks passed
@gaukas gaukas deleted the fix-memfs-write-err-success branch July 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikziyunchi erikziyunchi erikziyunchi approved these changes

Assignees

@gaukas gaukas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: memFS.WriteFile returned error: success
2 participants
@gaukas @erikziyunchi