Remove custom types in favor of Puppetlabs Stdlib Stdlib::Ensure::Package #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschonec
force-pushed
the
remove_custom_types
branch
3 times, most recently
from
188f51a to
64d7265
Compare
bschonec
commented
Feb 12, 2024
| @@ -10,7 +10,7 @@ | |||
| "dependencies": [ | |||
| { | |||
| "name": "puppetlabs-stdlib", | |||
| "version_requirement": ">= 6.0.0 < 9.0.0" | |||
| "version_requirement": ">= 8.6.0 < 9.0.0" | |||
There was a problem hiding this comment.
Stdlib::Ensure::Package first introduced.
|
Please rebase this PR. |
bschonec
force-pushed
the
remove_custom_types
branch
from
720796a to
7d3ec31
Compare
bschonec
force-pushed
the
remove_custom_types
branch
from
7d3ec31 to
2d1eddf
Compare
|
Rebased... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppetlabs has created a stdlib definition for Package states so there is no longer a need for the custom type, Samba::PackageState.