Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host_msdfs & inherit_acl & hosts allow & hosts deny parameters #58

Closed
wants to merge 11 commits into from

Conversation

dadez73
Copy link

@dadez73 dadez73 commented Sep 27, 2024

host_msdfs add missing parmeter to enable shares on dfs
inherit_acl add missing parmeter to enable parent inherited acl

@dadez73 dadez73 changed the title Add host_msdfs & inherit_acl parameters Add host_msdfs & inherit_acl & hosts allow & hosts deny parameters Sep 27, 2024
@rehanone
Copy link
Owner

rehanone commented Oct 9, 2024

Thanks for the pull request! Can you please squash your comments and confirm that you have tested these changes?

Doninelli Davide and others added 3 commits October 9, 2024 09:00
addede new parameter reference

added hosts_allow and hosts_deny and fixed key values host_msdfs and inherit_acl

updated deprecated hostname fact

regenerate REFERENCE file
@dadez73
Copy link
Author

dadez73 commented Oct 9, 2024

Hope i understood what you asked. Let me know if further modification are needed.
I tested on our machine and work as expected.

@rehanone
Copy link
Owner

rehanone commented Oct 9, 2024

This PR has 7 commits. Can you please squash them in a single commit?

Doninelli Davide and others added 4 commits October 9, 2024 10:06
addede new parameter reference

added hosts_allow and hosts_deny and fixed key values host_msdfs and inherit_acl

updated deprecated hostname fact

regenerate REFERENCE file

added hosts_allow and hosts_deny and fixed key values host_msdfs and inherit_acl

updated deprecated hostname fact

regenerate REFERENCE file
@dadez73
Copy link
Author

dadez73 commented Oct 9, 2024

hi, i close this PR.
I will create a new one from scratch.

@dadez73 dadez73 closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants