Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vhosts. #1

Merged
merged 1 commit into from
Mar 1, 2015
Merged

Add support for vhosts. #1

merged 1 commit into from
Mar 1, 2015

Conversation

apet
Copy link

@apet apet commented Feb 9, 2015

This patch introduces support for specifying a particular vhost.

@0x6e6562
Copy link
Member

0x6e6562 commented Feb 9, 2015

Thank you for your contribution. This patch looks fine. I think the CI build failure might be due to a change that has taken place in the Travis instances since the last successful build. So that fix, when found, will need to be applied on the master branch first before this can be merged.

0x6e6562 added a commit that referenced this pull request Mar 1, 2015
@0x6e6562 0x6e6562 merged commit 66292a8 into relops:master Mar 1, 2015
@0x6e6562
Copy link
Member

0x6e6562 commented Mar 1, 2015

@apet Very sorry for taking so long to address this issue :-(

It turns out that there is a bug in the Travis descriptor (see #2) which assumes that you have deployed a private encryption key for AWS credentials. This is completely irrelevant for a pull request, it is only relevant for publishing binaries to bintray, which is only necessary for master builds.

So I've created #2 for future pull requests, and your change has been merged - many thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants