Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN] Add modulo operator % #405

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[CN] Add modulo operator % #405

merged 1 commit into from
Jul 29, 2024

Conversation

MedranoApol
Copy link
Contributor

No description provided.

@MedranoApol MedranoApol marked this pull request as draft July 23, 2024 17:30
@MedranoApol MedranoApol marked this pull request as ready for review July 23, 2024 17:36
@elaustell
Copy link
Contributor

I think this looks great Apol! I have no suggestions except to squash.

Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, please rebase and squash if necessary and I'll merge asap.

Add OpRem_t to check.ml and CN_mod as a cn_binop in cn.lem

Add CN_mod definiton to mk_translate_binop in compile.ml

Add CN_mod to pp_cn_binop in cn_ocaml.ml

Add PERCENT symbol as a mul_expr in c_parser.mly

Update parser message to allow PERCENT as a mul_expr with CN

Add modulo test in tests/cn/
Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code needs formatting too - this was missed the first time because the pipelines stopped at the failing test (a file which tested for a crash on modulus, so that's expected). The cn-tutorial has been updated to remove the failing test temporarily and so after formatting, this should all be green.

@dc-mak dc-mak merged commit d7b47b7 into rems-project:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants