Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop DinD support in favor of install mode #298

Closed
viceice opened this issue May 16, 2023 · 3 comments · Fixed by #322
Closed

Drop DinD support in favor of install mode #298

viceice opened this issue May 16, 2023 · 3 comments · Fixed by #322
Assignees
@JamieMagee @viceice
Labels
breaking Breaking change, requires major version bump enhancement New feature or request

Comments

@viceice
Copy link
Member

viceice commented May 16, 2023 •
edited
Loading

This will simplify the chart a lot.
@viceice viceice added the breaking Breaking change, requires major version bump label May 16, 2023
@viceice viceice pinned this issue May 16, 2023
This was referenced May 16, 2023
Closed
Open
Closed
Closed
Closed
Closed
@viceice viceice added the enhancement New feature or request label May 16, 2023
@JamieMagee
Copy link
Contributor

Just to clarify, this is setting binarySource=install?

@viceice
Copy link
Member Author

viceice commented May 17, 2023

yes. it's essentially the same as docker mode, because we always install tool on the fly. we just don't use a sidecar container.

@viceice viceice mentioned this issue Jul 12, 2023
Merged
@viceice
Copy link
Member Author

viceice commented Jul 12, 2023

For anyone whos watching this, please see

@viceice viceice unpinned this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieMagee JamieMagee

@viceice viceice

Labels
breaking Breaking change, requires major version bump enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: migrate to renovate v36 renovatebot/helm-charts
2 participants
@JamieMagee @viceice