Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options to override command and args #1323

Merged
merged 2 commits into from
May 14, 2024

Conversation

Lowaiz
Copy link
Contributor

@Lowaiz Lowaiz commented May 10, 2024

We are running Renovate on few thousand repositories on a self-hosted Gitlab, and time to time, Gitlab produce a 429 return status code when POST/PUT a merge request, making a Renovate returning a non-zero code.

We don't really mind these fails, as it appears 2 or 3 times per run and renovate run twice a day.
But the set -e option let the cronjob as fail for Kubernetes, making it to be re run instantly, spamming the resources, without repeating the error on the same repo/branch.
So I propose to have an option to override the whole command and args part, to be able to override the set -e options

@Lowaiz
Copy link
Contributor Author

Lowaiz commented May 10, 2024

@viceice
Hello,

Here is the full override implem, asked in #1299.
I have a little doubt about the precedence to apply between commandOverride/argsOverride and the preCommand/postCommand options.
In the format, you can:

  • Override only the command, leaving empty args.
  • Override only the args, leaving the custom Renovate command: renovate. so permitting the addition of args to this command.
  • Override both for custom behavior.
  • No override and usage of pre and postCommand, to have no breaking change.

@Lowaiz
Copy link
Contributor Author

Lowaiz commented May 10, 2024

And for the naming of these options, I chose to use Override as it's already the case of few other options: nameOverride, fullNameOverride, ...

@viceice viceice changed the title feat(override-command): add options to override command and args feat: add options to override command and args May 10, 2024
@viceice
Copy link
Member

viceice commented May 14, 2024

related

@viceice viceice added this pull request to the merge queue May 14, 2024
Merged via the queue into renovatebot:main with commit f03ad6f May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants