Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow api version override #147

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 2, 2021

  • Allow api version override
  • Simply api version check
  • Add some docs

closes #145

@viceice viceice requested a review from JamieMagee August 2, 2021 07:35
@viceice viceice merged commit 4f9a44c into main Aug 3, 2021
@viceice viceice deleted the feat/allow-api-version-override branch August 3, 2021 09:22
@ekeih
Copy link

ekeih commented Aug 3, 2021

Hi, thanks for implementing this override @viceice! I just wanted to use helm template with this chart and was very happy to see that this change just got merged three hours ago 🙂
If I am not mistaken this release is not available at https://docs.renovatebot.com/helm-charts, is this on purpose? 🤔 (Maybe some automation didn't like the renovate-25.64.1+1 instead of renovate-25.64.2? 😄)

@ekeih
Copy link

ekeih commented Aug 3, 2021

https://github.com/renovatebot/helm-charts/releases/tag/renovate-25.65.0 seems to be publised to the helm repository now. Not sure if that was in response to this comment or not, but either way your work is greatly appreciated and the release seems to work! Thanks 🙂

@viceice
Copy link
Member Author

viceice commented Aug 3, 2021

We currently follow the main renovate versions, so i can only publish the chart with a sub version +1 but the chart-releaser tool won't publish it to the gh-pages 😕

Maybe some knows better tooling for automated helm chart releasing. Currently all we need to do is to wait for next automatic renovate release, which will be multiple times a day

@viceice
Copy link
Member Author

viceice commented Aug 3, 2021

see also #54

@ekeih
Copy link

ekeih commented Aug 4, 2021

I see, thanks for the explanation @viceice! Normally, waiting for the next automated release should be fine, yesterday I was just trying to use it too fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD: "You must have atleast batch/v1beta1 to use CronJob"
2 participants