Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RENOVATE_CONFIG_FILE not being rendered #174

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

roobre
Copy link
Contributor

@roobre roobre commented Dec 11, 2021

@roobre
Copy link
Contributor Author

roobre commented Dec 11, 2021

Personally I'd rather get rid of such a massively complex if clause, as it can easily hide bugs like this one, but I preferred to keep the PR simple.

@viceice viceice changed the title fix RENOVATE_CONFIG_FILE not being rendered fix: RENOVATE_CONFIG_FILE not being rendered Dec 11, 2021
@viceice
Copy link
Member

viceice commented Dec 11, 2021

Personally I'd rather get rid of such a massively complex if clause, as it can easily hide bugs like this one, but I preferred to keep the PR simple.

Thanks, can you refactor the condition in another pr after this?

@roobre
Copy link
Contributor Author

roobre commented Dec 11, 2021

@viceice Sure, let me give it a try :)

@viceice
Copy link
Member

viceice commented Dec 11, 2021

@viceice Sure, let me give it a try :)

Thanks, please try to use semantic commit messages or simply push miltiple commits to pass Semantic Pull Request check 😉

@viceice viceice merged commit 5872c09 into renovatebot:main Dec 11, 2021
@viceice
Copy link
Member

viceice commented Dec 11, 2021

This will be published with next renovate release, see #54 for reason

@roobre
Copy link
Contributor Author

roobre commented Dec 11, 2021

Awesome, thanks for the quick review!

I've created a draft getting rid of the if entirely here: #175

There are more complex options available but personally I'm not sure if they are worth the added complexity. I'll be happy to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate config is not correctly read on v30 Authentication failure after update to v30
2 participants